On Tue, Jun 7, 2016 at 7:47 PM, Ashutosh Bapat wrote: > On Tue, Jun 7, 2016 at 4:07 PM, Amit Langote wrote: >> On 2016/06/07 19:13, Ashutosh Bapat wrote: >> > So, your patch looks to be the correct approach (even after we support >> > deparsing subqueries). Can you please include a test in regression? >> >> I added a slightly modified version of your test to the originally posted >> patch. >> > Looks good to me. If we add a column from the outer relation, the "NULL"ness > of inner column would be more clear. May be we should tweak the query to > produce few more rows, some with non-NULL columns from both the relations. > Also add a note to the comment in the test mentioning that such a join won't > be pushed down for a reader to understand the EXPLAIN output. Also, you > might want to move that test, closer to other un-pushability tests.
Done in the attached. Please check if my comment explains the reason of push-down failure correctly. Thanks, Amit
pgfdw-join-pd-bug-3.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
