On Mon, Apr 25, 2016 at 4:29 AM, Christian Ullrich <ch...@chrullrich.net> wrote: > Andrew wrote: >> OK, here's my final version of the patch, which I will apply in 24 hours > or so unless there is an objection.
Thanks Andrew for the updated patch! > This one doesn't matter, but just for perfection's sake: > > +#if (_MSC_VER >= 1900) > + uint32 cp; > + WCHAR wctype[80]; > + > + memset(wctype, 0, 80 * sizeof(WCHAR)); > + MultiByteToWideChar(CP_ACP, 0, ctype, -1, wctype, 80); > > The maximum length is documented as 85 characters, also: > > <https://msdn.microsoft.com/en-us/library/windows/desktop/dd373815(v=vs.85).aspx>: > 'Note Your application must use the constant [LOCALE_NAME_MAX_LENGTH] for > the maximum locale name length, instead of hard-coding the value "85".' Just an addition on top of the comments of Christian.. +#pragma warning(push) +#pragma warning(disable : 4091) #include <dbghelp.h> +#pragma warning(pop) It seems to me that we had better protect those pragmas with _MSC_VER >= 1900. The crash dump facility could be used by MinGW as well, no? -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
