Thomas Munro wrote: > On Sat, Apr 23, 2016 at 4:36 AM, Andres Freund <and...@anarazel.de> wrote: > > On 2016-04-22 20:39:27 +1200, Thomas Munro wrote: > >> While doing that I discovered that unpatched master doesn't actually > >> build on recent NetBSD systems because our static function strtoi > >> clashes with a non-standard libc function of the same name[1] declared > >> in inttypes.h. Maybe we should rename it, like in the attached? > > > > Yuck. That's a new function they introduced? That code hasn't changed in > > a while.... > > Yes, according to the man page it appeared in NetBSD 7.0. That was > released in September 2015, and our buildfarm has only NetBSD 5.x > systems. I see that the maintainers of the NetBSD pg package deal > with this with a preprocessor kludge: > > http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/databases/postgresql95/patches/patch-src_backend_utils_adt_datetime.c?rev=1.1 > > What is the policy for that kind of thing -- do nothing until someone > cares enough about the platform to supply a buildfarm animal?
Well, if the platform is truly alive, we would have gotten complaints already. Since we haven't, maybe nobody cares, so why should we? I would rename our function nonetheless FWIW; the name seems far too generic to me. pg_strtoi? -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
