Re: [HACKERS] [PATCH] Phrase search ported to 9.6

[Teodor Sigaev]

Looking at patch, I'm inlined to commit it in current commitfest, it looks workable and too many people desire it. I've did some changes, mostly in formatting and comments.

Patch makes some user-visible changes:

2 less number of parenthesis in tsquery output, and tsquery becomes more 
readable.




Dmitry Ivanov wrote:

1 change order for tsquery. Assume, it's acceptable, only a few users store tsquery in table and have a Btree index. They will need to reindex. Pls, remove tsquery_setweight from patch because it's not a part of phrase search and it isn't mentioned in docs. Please, make a separate patch for it.

Sorry for the delay, I desperately needed some time to finish a bunch of
dangling tasks.

I've added some new comments and clarified the ones that were obscure.
Moreover, I felt an urge to recheck most parts of the code since apparently
nobody (besides myself) has gone so far yet.

On 25.03.16 18:42 MSK, David Steele wrote:

Time is short and it's not encouraging that you say there is "still much

work to be done".

Indeed, I was inaccurate. I am more than interested in the positive outcome.

--
Teodor Sigaev                                   E-mail: teo...@sigaev.ru
                                                   WWW: http://www.sigaev.ru/

phrase-0.4.patch
Description: binary/octet-stream

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers