On Wed, Mar 23, 2016 at 1:13 PM, Michael Paquier <michael.paqu...@gmail.com> wrote:
> > + /* > + * Compute targetRecOff. It should typically be greater than short > + * page-header since a valid record can't , but can also be zero > when > + * caller has supplied a page-aligned address or when we are > skipping > + * multi-page continuation record. It doesn't matter though because > + * ReadPageInternal() will read at least short page-header worth of > + * data > + */ > This needs some polishing, there is an unfinished sentence here. > > + targetRecOff = tmpRecPtr % XLOG_BLCKSZ; > targetRecOff, pageHeaderSize and targetPagePtr could be declared > inside directly the new while loop. > Thanks Michael for reviewing the patch. I've fixed these issues and new version is attached. Thanks, Pavan -- Pavan Deolasee http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
xlogdump_multipage_cont_record_v2.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
