> -----Original Message----- > From: pgsql-hackers-ow...@postgresql.org > [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Petr Jelinek > Sent: Thursday, March 17, 2016 5:06 PM > To: Kaigai Kouhei(海外 浩平) > Cc: Robert Haas; pgsql-hackers@postgresql.org > Subject: Re: [HACKERS] Reworks of CustomScan serialization/deserialization > > On 15/03/16 05:03, Kouhei Kaigai wrote: > > Petr, > > > > The attached patch is the revised one that follows the new extensible- > > node routine. > > > > It is almost same the previous version except for: > > - custom-apis.[ch] was renamed to custom-node.[ch] > > - check for the length of custom-scan-method name followed > > the manner of RegisterExtensibleNodeMethods() > > > > Hi, > > looks good, only nitpick I have is that it probably should be > custom_node.h with underscore given that we use underscore everywhere > (except for libpq and for some reason atomic ops). > Sorry for my response late.
The attached patch just renamed custom-node.[ch] by custom_node.[ch]. Other portions are not changed from the previous revison. Thanks, -- NEC Business Creation Division / PG-Strom Project KaiGai Kohei <kai...@ak.jp.nec.com> -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
