On 2016/03/12 6:31, Peter Geoghegan wrote: > On Thu, Mar 10, 2016 at 9:18 AM, Tomas Vondra > <tomas.von...@2ndquadrant.com> wrote: >> I've looked at this patch today, mostly to educate myself, so this >> probably should not count as a full review. Anyway, the patch seems in >> excellent shape - it'd be great if all patches (including those written >> by me) had this level of comments/docs.
+1 >> Can we come up with names that more clearly identify the difference >> between those two functions? I mean, _parent_ does not make it >> particularly obvious that the second function acquires exclusive lock >> and performs more thorough checks. > > Dunno about that. It's defining characteristic is that it checks child > pages against their parent IMV. Things are not often defined in terms > of their locking requirements. At the risk of sounding a bit verbose, do bt_check_level() for a check that inspects a level at a time and bt_check_multi_level() for a check that spans levels sound descriptive? Thanks, Amit -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
