On Tue, Feb 23, 2016 at 12:29 AM, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > Craig Ringer wrote: > >> > +=pod >> > + >> > +=head2 Set up a node >> > pod format... Do we really want that? Considering that those modules >> > are only aimed at being dedicated for in-core testing, I would say no. >> >> If it's plain comments you have to scan through massive piles of verbose >> Perl to find what you want. If it's pod you can just perldoc >> /path/to/module it and get a nice summary of the functions etc. >> >> If these are intended to become usable facilities for people to write tests >> with then I think it's important that the docs be reasonably accessible. > > Yes, I think adding POD here is a good idea. I considered doing it > myself back when I was messing with PostgresNode ...
OK, withdrawal from here. If there are patches to add that to the existing tests, I'll review them, and rebase what I have depending on what gets in first. Could a proper patch split be done please? -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
