On 2/16/16, Vitaly Burovoy <vitaly.buro...@gmail.com> wrote: > On 2/16/16, Dean Rasheed <dean.a.rash...@gmail.com> wrote: >> Fixing that in parse_memory_unit() would be messy because it assumes a >> base unit of kB, so it would require a negative multiplier, and >> pg_size_bytes() would have to be taught to divide by the magnitude of >> negative multipliers in the same way that guc.c does.
Now parse_memory_unit returns -1024 for bytes as divider, constant "bytes" has moved there. Add new memory_units_bytes_hint which differs from an original memory_units_int by "bytes" size unit. Allow hintmsg be NULL and if so, skip setting dereferenced variable to memory_units_bytes_hint. >> ISTM that it would be far less code, and much simpler and more >> readable to just parse the supported units directly in >> pg_size_bytes(), rather than trying to share code with guc.c, when the >> supported units are actually different and may well diverge further in >> the future. > > Initially it was not shared with guc.c and now it is by the letter[1] > of Oleksandr Shulgin and Robert Haas. > >> I'll try to hack something up, and see what it looks like. >> >> Regards, >> Dean Current version contains correct hint message, it passes tests. Besides mentioned above there are some comment rewordings, and variable renaming. [1]http://www.postgresql.org/message-id/ca+tgmoanot7ugjsbibfuqgachk2lzrypmkjvvugp5r197yu...@mail.gmail.com -- Best regards, Vitaly Burovoy
pg-size-bytes-11chgd2.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
