On Wed, Feb 10, 2016 at 3:45 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Simon Riggs <si...@2ndquadrant.com> writes: >> Your patch looks right to me, so I will commit, barring objections... with >> backpatch. Likely to 9.0, AFAICS. > > 9.0 is out of support and should not be patched anymore. > > I agree that the patch is basically correct, though I'd personally > write it without bothering with the extra variable: > > + /* must account for wraparound */ > + if (startPage > TransactionIdToPage(0xFFFFFFFF)) > + startPage = 0; > > Also, the comment at line 45 is now wrong and needs an addition.
Instead of using a hardcoded value, wouldn't it be better to use something based on MaxTransactionId? -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
