I wrote: > In any case, we should proceed with fixing things so that buildfarm owners > can specify a higher shutdown timeout for especially slow critters.
I looked into doing this as I suggested yesterday, namely modifying the buildfarm scripts, and soon decided that it would be a mess; there are too many cases where "pg_ctl stop" is not invoked directly by the script. I'm now in favor of applying the PGCTLTIMEOUT patch Noah proposed, and *removing* the two existing hacks in run_build.pl that try to force -t 120. The only real argument I can see against that approach is that we'd have to back-patch the PGCTLTIMEOUT patch to all active branches if we want to stop the buildfarm failures. We don't usually back-patch feature additions. On the other hand, this wouldn't be the first time we've back-patched something on grounds of helping the buildfarm, so I find that argument pretty weak. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers