On Tue, Feb 2, 2016 at 10:05 PM, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > This patch has gotten its fair share of feedback in this fest. I moved > it to the next commitfest. Please do keep working on it and reviewers > that have additional comments are welcome.
Thanks! On Tue, Feb 2, 2016 at 8:59 PM, Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> wrote: > Since the destination version is fixed, the advantage of the > plugin mechanism for pg_upgade would be capability to choose a > plugin to load according to some characteristics of the source > database. What do you think the trigger characteristics for > convertLayoutVM_add_frozenbit.so or similars? If it is hard-coded > like what transfer_single_new_db is doing for fsm and vm, I > suppose the module is not necessary to be a plugin. Sorry, I couldn't get it. You meant that we should use rewriteVisibilityMap as a function (not dynamically load)? The destination version is not fixed, it depends on new cluster version. I'm planning that convertLayoutVM_add_frozenbit.so is dynamically loaded and used only when rewriting of VM is required. If layout of VM will be changed again in the future, we could add other libraries for convert Regards, -- Masahiko Sawada -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
