On Fri, Jan 29, 2016 at 3:46 AM, Ashutosh Bapat <ashutosh.ba...@enterprisedb.com> wrote: > PFA patch to move code to deparse SELECT statement into a function > deparseSelectStmtForRel(). This code is duplicated in > estimate_path_cost_size() and postgresGetForeignPlan(), so moving it into a > function avoids that duplication. As a side note, estimate_path_cost_size() > doesn't add FOR SHARE/UPDATE clause to the statement being EXPLAINed, even > if the actual statement during execution would have it. This difference > looks unintentional to me. This patch corrects it as well. > appendOrderByClause and appendWhereClause both create a context within > themselves and pass it to deparseExpr. This patch creates the context once > in deparseSelectStmtForRel() and then passes it to the other deparse > functions avoiding repeated context creation.
Right, OK. I think this is good, so, committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
