Re: Alvaro Herrera 2016-01-04 <20160104175623.GA170910@alvherre.pgsql> > > https://reproducible.debian.net/dbd/unstable/armhf/postgresql-9.4_9.4.5-2.diffoscope.html
9.5 was already tested as well, I just couldn't find the link yesterday: https://reproducible.debian.net/rb-pkg/experimental/armhf/postgresql-9.5.html Again, the only real difference between the two builds there is in pg_xlogdump, the remaining differences are about the checksums of the surrounding containers (.deb files are really ar files containing tarballs). > Ugh. I guess this output is helpful enough given that it mentions the > offending executable; since our Makefiles are simple enough, we > shouldn't have much trouble finding the problem spot. I do wonder if > the CMake conversion is going to cause problems. cmake is writing makefiles, so I wouldn't expect much problems. (But it could be the case that problems are harder to fix.) > > > At least transform modules added in 9.5 (hstore_plpython et al) look > > > like they might similar issues. > > Hmm. hstore_plperl uses $(wildcard) but only in the AIX and Win32 > cases, unless I'm misreading. > > I don't see any other $(wildcard) used to build executables; it's used > for tests and flags in many places, but that shouldn't matter. Nod. Attached is a patch that covers all relevant $(wildcard) occurrences in Makefiles for devel. contrib/hstore_plperl/Makefile | 2 !! contrib/hstore_plpython/Makefile | 4 !!!! contrib/ltree_plpython/Makefile | 4 !!!! src/bin/pg_xlogdump/Makefile | 2 !! 4 files changed, 12 modifications(!) Mit freundlichen Grüßen, Christoph Berg -- Senior Berater, Tel.: +49 (0)21 61 / 46 43-187 credativ GmbH, HRB Mönchengladbach 12080, USt-ID-Nummer: DE204566209 Hohenzollernstr. 133, 41061 Mönchengladbach Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer pgp fingerprint: 5C48 FE61 57F4 9179 5970 87C6 4C5A 6BAB 12D2 A7AE
diff --git a/contrib/hstore_plperl/Makefile b/contrib/hstore_plperl/Makefile new file mode 100644 index 8f7b171..b3b8654 *** a/contrib/hstore_plperl/Makefile --- b/contrib/hstore_plperl/Makefile *************** endif *** 32,38 **** ifeq ($(PORTNAME), win32) # these settings are the same as for plperl override CPPFLAGS += -DPLPERL_HAVE_UID_GID -Wno-comment ! SHLIB_LINK += ../hstore/libhstore.a $(wildcard ../../src/pl/plperl/libperl*.a) endif ifeq ($(PORTNAME), cygwin) --- 32,38 ---- ifeq ($(PORTNAME), win32) # these settings are the same as for plperl override CPPFLAGS += -DPLPERL_HAVE_UID_GID -Wno-comment ! SHLIB_LINK += ../hstore/libhstore.a $(sort $(wildcard ../../src/pl/plperl/libperl*.a)) endif ifeq ($(PORTNAME), cygwin) diff --git a/contrib/hstore_plpython/Makefile b/contrib/hstore_plpython/Makefile new file mode 100644 index 2de00a2..c4dad6f *** a/contrib/hstore_plpython/Makefile --- b/contrib/hstore_plpython/Makefile *************** endif *** 27,36 **** # dependency. This does preclude pgxs builds. ifeq ($(PORTNAME), aix) rpathdir = $(pkglibdir):$(python_libdir) ! SHLIB_LINK += ../hstore/libhstore.exp $(python_libspec) $(python_additional_libs) $(wildcard ../../src/pl/plpython/libplpython*.exp) endif ifeq ($(PORTNAME), win32) ! SHLIB_LINK += ../hstore/libhstore.a $(wildcard ../../src/pl/plpython/libpython*.a) $(wildcard ../../src/pl/plpython/libplpython*.a) endif ifeq ($(PORTNAME), cygwin) --- 27,36 ---- # dependency. This does preclude pgxs builds. ifeq ($(PORTNAME), aix) rpathdir = $(pkglibdir):$(python_libdir) ! SHLIB_LINK += ../hstore/libhstore.exp $(python_libspec) $(python_additional_libs) $(sort $(wildcard ../../src/pl/plpython/libplpython*.exp)) endif ifeq ($(PORTNAME), win32) ! SHLIB_LINK += ../hstore/libhstore.a $(sort $(wildcard ../../src/pl/plpython/libpython*.a)) $(sort $(wildcard ../../src/pl/plpython/libplpython*.a)) endif ifeq ($(PORTNAME), cygwin) diff --git a/contrib/ltree_plpython/Makefile b/contrib/ltree_plpython/Makefile new file mode 100644 index 7eacb40..08186f1 *** a/contrib/ltree_plpython/Makefile --- b/contrib/ltree_plpython/Makefile *************** endif *** 27,36 **** # dependency. This does preclude pgxs builds. ifeq ($(PORTNAME), aix) rpathdir = $(pkglibdir):$(python_libdir) ! SHLIB_LINK += $(python_libspec) $(python_additional_libs) $(wildcard ../../src/pl/plpython/libplpython*.exp) endif ifeq ($(PORTNAME), win32) ! SHLIB_LINK += $(wildcard ../../src/pl/plpython/libpython*.a) $(wildcard ../../src/pl/plpython/libplpython*.a) endif ifeq ($(PORTNAME), cygwin) --- 27,36 ---- # dependency. This does preclude pgxs builds. ifeq ($(PORTNAME), aix) rpathdir = $(pkglibdir):$(python_libdir) ! SHLIB_LINK += $(python_libspec) $(python_additional_libs) $(sort $(wildcard ../../src/pl/plpython/libplpython*.exp)) endif ifeq ($(PORTNAME), win32) ! SHLIB_LINK += $(sort $(wildcard ../../src/pl/plpython/libpython*.a)) $(sort $(wildcard ../../src/pl/plpython/libplpython*.a)) endif ifeq ($(PORTNAME), cygwin) diff --git a/src/bin/pg_xlogdump/Makefile b/src/bin/pg_xlogdump/Makefile new file mode 100644 index 315e869..11df47d *** a/src/bin/pg_xlogdump/Makefile --- b/src/bin/pg_xlogdump/Makefile *************** OBJS = pg_xlogdump.o compat.o xlogreader *** 12,18 **** override CPPFLAGS := -DFRONTEND $(CPPFLAGS) ! RMGRDESCSOURCES = $(notdir $(wildcard $(top_srcdir)/src/backend/access/rmgrdesc/*desc.c)) RMGRDESCOBJS = $(patsubst %.c,%.o,$(RMGRDESCSOURCES)) --- 12,18 ---- override CPPFLAGS := -DFRONTEND $(CPPFLAGS) ! RMGRDESCSOURCES = $(sort $(notdir $(wildcard $(top_srcdir)/src/backend/access/rmgrdesc/*desc.c))) RMGRDESCOBJS = $(patsubst %.c,%.o,$(RMGRDESCSOURCES))
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
