On Tue, Jan 5, 2016 at 10:13 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Michael Paquier <michael.paqu...@gmail.com> writes: >> So, here are the commands that still remain with TailMatches to cover >> this case, per gram.y: >> - CREATE TABLE >> - CREATE INDEX >> - CREATE VIEW >> - GRANT >> - CREATE TRIGGER >> - CREATE SEQUENCE >> New patches are attached. > > I've reviewed and committed the first of these patches. I found a few > mistakes, mostly where you'd converted TailMatches to Matches without > adding the leading words that the original author had left out of the > pattern. But man, this is mind-numbingly tedious work :-(. I probably > made a few more mistakes myself. Still, the code is enormously more > readable now than when we started, and almost certainly more reliable.
Thanks. My best advice is to avoid doing such after 10PM, that's a good way to finish with a headache. I did it. > I'm too burned out to look at the second patch tonight, but hopefully > will get to it tomorrow. I see that you are on fire these days, still bodies need some rest. This second one still applies cleanly, but it is far less urgent, the other psql-tab patches do not depend on it. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
