On Sun, Jan 3, 2016 at 7:21 PM, Tomasz Rybak <tomasz.ry...@post.pl> wrote:
> The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: not tested > Spec compliant: not tested > Documentation: tested, failed > > Applies cleanly on current master > (b416c0bb622ce5d33fdbec3bbce00451132f10ec). > > Builds without any problems on current Debian unstable (am64 arch, GCC > 5.3.1-4, glibc 2.21-6) > A make from an external build dir fails on install, suggested fix: install: all $(MKDIR_P) '$(DESTDIR)$(includedir)'/pglogical_output - $(INSTALL_DATA) pglogical_output/hooks.h '$(DESTDIR)$(includedir)'/pglogical_output + $(INSTALL_DATA) $(top_srcdir)/contrib/pglogical_output/pglogical_output/hooks.h '$(DESTDIR)$(includedir)'/pglogical_output -- Alex