On Tue, Dec 29, 2015 at 2:26 PM, Amit Kapila <amit.kapil...@gmail.com> wrote:
> On Wed, Dec 16, 2015 at 12:26 AM, Robert Haas <robertmh...@gmail.com> > wrote: > > > > > > In terms of this project overall, NumLWLocks() now knows about only > > four categories of stuff: fixed lwlocks, backend locks (proc.c), > > replication slot locks, and locks needed by extensions. I think it'd > > probably be fine to move the backend locks into PGPROC directly, and > > the replication slot locks into ReplicationSlot. > > > > IIdus has written a patch to move backend locks into PGPROC which > I am reviewing and will do performance tests once he responds to > my review comments and I have written a patch to move replication > slot locks into ReplicationSlot which is attached with this mail. > > Going further on this work, I have written a patch for separating the tranches for extensions. The basic idea is to expose two new API's, first to request a new tranche and second to assign a lock from that tranche. RequestAddinLWLockTranche(const char *tranche_name, int num_lwlocks) will be used by extensions to request a new tranche with specified number of locks, this will be used instead of current API RequestAddinLWLocks(). We need to remember this information for each extension and then during startup we need to create separate tranches and still have locks for extensions in the MainLWLockArray such that the base for each tranche will point to the locks corresponding to that tranche. As for each proc/backend, we need to register the tranche separately, the information of newly formed tranches needs to be passed to backends via save/restore_backend_variables mechanism for EXEC_BACKEND builds. LWLock *LWLockAssignFromTranche(const char *tranche_name) will assign a lock for the specified tranche. This also ensures that no more than requested number of LWLocks can be assigned from a specified tranche. Also I have retained NUM_USER_DEFINED_LWLOCKS in MainLWLockArray so that if any extensions want to assign a LWLock after startup, it can be used from this pool. The tranche for such locks will be reported as main. This is based on the suggestions by Robert in the mail: http://www.postgresql.org/message-id/CA+TgmoashjaQeSK1bEm-GGc8OWFyLhvOrH=4kjfvkrft9yk...@mail.gmail.com Thoughts? With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
separate_tranche_extensions_v1.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
