Hi Vinayak, On 2015/12/25 21:46, Vinayak Pokale wrote: > Hi, > Please find attached patch addressing following comments. > >> The relation OID should be reported and not its name. In case of a >> relation rename that would not be cool for tracking, and most users >> are surely going to join with other system tables using it. > The relation OID is reported instead of relation name. > The following interface function is called at the beginning to report the > relation OID once. > void pgstat_report_command_target(Oid relid) > >> Regarding pg_stat_get_vacuum_progress(): I think a backend can simply be >> skipped if (!has_privs_of_role(GetUserId(), beentry->st_userid)) (cannot >> put that in plain English, :)) > Updated in the attached patch. > > In the previous patch, ACTIVITY_IS_VACUUM is set unnecessarily for > VACOPT_FULL and they are not covered by lazy_scan_heap(). > I have updated it in attached patch and also renamed ACTIVITY_IS_VACUUM to > COMMAND_LAZY_VACUUM. > > Added documentation for view. > Some more comments need to be addressed.
I suspect you need to create a new CF entry for this patch in CF 2016-01. Thanks, Amit -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
