Hello, I think I found a typo in a comment of syncrep.c. > * acknowledge the commit nor raise ERROR or FATAL. The latter would > - * lead the client to believe that that the transaction aborted, which > * is not true: it's already committed locally. The former is no good
The 'that' looks duplicate. And it might be better to put a be-verb before the 'aborted'. > + * lead the client to believe that the transaction is aborted, which regards, -- Kyotaro Horiguchi NTT Open Source Software Center
>From 6eb92736d318f6be35459d4406585aa34233bd5d Mon Sep 17 00:00:00 2001 From: Kyotaro Horiguchi <horiguchi.kyot...@lab.ntt.co.jp> Date: Wed, 16 Dec 2015 16:52:19 +0900 Subject: [PATCH] fix typo of syncrep.c --- src/backend/replication/syncrep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/replication/syncrep.c b/src/backend/replication/syncrep.c index 325239d..98f7d73 100644 --- a/src/backend/replication/syncrep.c +++ b/src/backend/replication/syncrep.c @@ -183,7 +183,7 @@ SyncRepWaitForLSN(XLogRecPtr XactCommitLSN) /* * If a wait for synchronous replication is pending, we can neither * acknowledge the commit nor raise ERROR or FATAL. The latter would - * lead the client to believe that that the transaction aborted, which + * lead the client to believe that the transaction is aborted, which * is not true: it's already committed locally. The former is no good * either: the client has requested synchronous replication, and is * entitled to assume that an acknowledged commit is also replicated, -- 1.8.3.1
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
