- bits_len = tuphdr->t_hoff - - offsetof(HeapTupleHeaderData, t_bits); + int bits_len = + ((tuphdr->t_infomask2 & HEAP_NATTS_MASK) / 8 + 1) * 8;
As I understand offline comments of Nikolay, current version of page inspect contains an mistake here. Should we backpatch this?
OK. I have switched the status of this patch to "Ready for committer" (please, committer-san, double-check the area around tuple_data_split_internal when fetching data for each attribute, I think that we got that right but I may be missing something as well).
Looks good for a first glance -- Teodor Sigaev E-mail: teo...@sigaev.ru WWW: http://www.sigaev.ru/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers