While auditing the access method code associated with ON CONFLICT DO
UPDATE's speculative insertion infrastructure, I noticed an
inaccuracy.

Attached patch fixes the trivial inaccuracy in a defensive elog()
call. Quite simply, this call site didn't get the memo when we renamed
that function during the late stages of development.

-- 
Peter Geoghegan
diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c
index 35a2b05..72611fb 100644
--- a/src/backend/access/heap/heapam.c
+++ b/src/backend/access/heap/heapam.c
@@ -5809,7 +5809,7 @@ heap_finish_speculative(Relation relation, HeapTuple tuple)
 		lp = PageGetItemId(page, offnum);
 
 	if (PageGetMaxOffsetNumber(page) < offnum || !ItemIdIsNormal(lp))
-		elog(ERROR, "heap_confirm_insert: invalid lp");
+		elog(ERROR, "heap_finish_speculative: invalid lp");
 
 	htup = (HeapTupleHeader) PageGetItem(page, lp);
 
-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to