On Thu, Oct 29, 2015 at 8:18 PM, Alexander Korotkov < a.korot...@postgrespro.ru> wrote:
> On Thu, Sep 24, 2015 at 6:36 PM, Alexander Korotkov < > a.korot...@postgrespro.ru> wrote: > >> On Thu, Sep 24, 2015 at 6:32 PM, Andres Freund <and...@anarazel.de> >> wrote: >> >>> On 2015-09-15 20:16:10 +0300, YUriy Zhuravlev wrote: >>> > We will be tested. >>> >>> Did you have a chance to run some benchmarks? >>> >> >> Yes, we now have 60 physical cores intel server and we're running >> benchmarks on it. >> > > We got a consensus with Andres that we should commit the CAS version first > and look to other optimizations. > Refactored version of atomic state patch is attached. The changes are > following: > 1) Macros are used for access refcount and usagecount. > 2) likely/unlikely were removed. I think introducing of likely/unlikely > should be a separate patch since it touches portability. Also, I didn't see > any performance effect of this. > 3) LockBufHdr returns the state after taking lock. Without using atomic > increments it still can save some loops on skip atomic value reading. > pinunpin-cas-original-fix.patch is just original patch by Andres Freund with fixed bug which causes hang. Performance comparison on 72-cores Intel server in attached. On this machine we see no regression in version of patch in previous letter. ------ Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company
n_clients,master,pinunpin-cas-original-fix,pinunpin-cas
1, 18860, 19421, 19972
8, 162503, 166901, 164363
16, 316429, 321103, 319214
36, 627215, 641028, 642854
56, 745108, 774195, 786642
90, 847150, 995036, 1022657
100, 802922, 1077732, 1083769
110, 615070, 1014446, 1034496
120, 611956, 1074345, 1094610
130, 571697, 1082626, 1100578
140, 579909, 1075855, 1092749
150, 540442, 1070737, 1089283
160, 545942, 1068991, 1096360
170, 515444, 1073508, 1089891
180, 520867, 1076281, 1093987
190, 488836, 1071283, 1097871
200, 493795, 1082849, 1103040
210, 463765, 967185, 988692
220, 467661, 972180, 993521
230, 437297, 976865, 980113
250, 420711, 956151, 980965
pinunpin-cas-original-fix.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
