On Thu, Oct 22, 2015 at 4:11 PM, Torsten Zühlsdorff <mailingli...@toco-domains.de> wrote: > On 21.10.2015 02:05, Masahiko Sawada wrote: >> >> On Sat, Oct 10, 2015 at 4:20 AM, Robert Haas <robertmh...@gmail.com> >> wrote: >>> >>> On Thu, Oct 8, 2015 at 1:52 PM, Andres Freund <and...@anarazel.de> wrote: >>>> >>>> I don't see the problem? I mean catversion will reliably tell you which >>>> format the vm is in? >>> >>> >>> Totally agreed. >>> >>>> We could additionally use the opportunity to as a metapage, but that >>>> seems like an independent thing. >>> >>> >>> I agree with that, too. >>> >> >> Attached the updated v18 patch fixes some bugs. >> Please review the patch. > > > I've just checked the comments:
Thank you for taking the time to review this patch. Attached updated patch(v19). > File: /doc/src/sgml/catalogs.sgml > > + Number of pages that are marked all-frozen in the tables's > Should be: > + Number of pages that are marked all-frozen in the tables I changed it as follows. + Number of pages that are marked all-frozen in the table's The similar sentence of relallvisible is exist. > + <command>ANALYZE</command>, and a few DDL coomand such as > Should be: > + <command>ANALYZE</command>, and a few DDL command such as Fixed. > File: doc/src/sgml/maintenance.sgml > > + When the all pages of table are eventually marked as frozen by > <command>VACUUM</>, > Should be: > + When all pages of the table are eventually marked as frozen by > <command>VACUUM</>, Fixed. > File: /src/backend/access/heap/visibilitymap.c > > + * visibility map bit. Then, we lock the buffer. But this creates a race > Should be: > + * visibility map bit. Than we lock the buffer. But this creates a race I didn't change this sentence actually. so kept it. > + * buffer, the PD_ALL_VISIBLE or PD_ALL_FROZEN bit gets set. If that > happens, > Should be: > + * buffer, the PD_ALL_VISIBLE or PD_ALL_FROZEN bit gets set. If that > happens, > (Remove duplicate white space before if) The other sentence seems to have double white space after period. I kept it. Please review it. Regards, -- Masahiko Sawada
000_add_frozen_bit_into_visibilitymap_v19.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
