Andres Freund wrote: > On 2015-10-21 17:21:25 -0300, Alvaro Herrera wrote:
> > I think the first assignment is also pointless -- I mean can't we just > > use MyReplicationSlot->data.name in both places where slot_name is used? > > Makes the lines a bit long. strlen(NameStr(MyReplicationSlot->data.name)) ... Meh. Assign the strlen somewhere? > > In the same routine, it seems wasteful to be doing strlen() twice for > > every string sent over the wire. > > That seems fairly insignificant. For one this is a rather infrequent and > expensive operation, OK, I can buy that. > for another every decent compiler can optimize those away. Note that > those duplicate strlen() calls are there in a lot of places in > walsender.c It can? Tom has repeatedly argue the opposite, in the past. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
