On Thu, Oct 15, 2015 at 8:35 PM, Dmitry Vasilyev <d.vasil...@postgrespro.ru> wrote:
> I think that function dsm_impl_windows() with EACCES error should not > do ereport() with FATAL level. It works, but it is likely to make an > infinite loop if the user will receive EACCES error. > > Currently we are using error level as ERROR for creating dsm during postmaster startup which is not right and rather we should use error level as LOG. Can you please try with the attached patch and see if the issue is fixed for you. Another some what related point is currently we are using random() function to ensure a unique name for dsm and it seems to me that it is always going to generate same number on first invocation (at least thats what happening on windows) due to which you are seeing the error. Another options could be to append current pid or data directory path as we are doing in win32_shmem.c. I think this could be an optimization which can be done in addition to the fix attached (we can do this as a separate patch as well, if we agreed to do anything). With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
fix_dsm_pm_startup_issue_v1.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
