Hello Tom! On Пн, 2015-10-12 at 16:35 -0400, Tom Lane wrote: > I wrote: > > This is kind of a mess :-(. But it does look like what we want is > > for SubPostmasterMain to do more than nothing when it chooses not > > to > > reattach. Probably that should include resetting UsedShmemSegAddr > > to > > NULL, as well as closing the handle. > > After poking around a bit more, I propose the attached patch. I've > checked that this is happy with an EXEC_BACKEND Unix build, but I'm > not > able to test it on Windows ... would somebody do that? > > BTW, it appears from this that Cygwin builds have been broken right > along > in a different way: according to the code in sysv_shmem's > PGSharedMemoryReAttach, Cygwin does cause a re-attach to occur, which > we > were not undoing for putatively-not-connected-to-shmem child > processes. > That's a robustness problem because it breaks the postmaster's > expectation > that it's safe to not reinitialize shmem after a crash of one of > those > processes. I believe this patch fixes that problem as well, though > if > anyone can test it on Cygwin that wouldn't be a bad thing either. > > regards, tom lane >
This patch is working for me, binaries: https://goo.gl/32j7QE (MSVC 2010, build script here: https://github.com/postgrespro/pgwininstall). ------ Dmitry Vasilyev Postgres Professional: http://www.postgrespro.com The Russian Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
