On 2015/10/02 15:38, Fujii Masao wrote: > > + uint32 progress_param[N_PROGRESS_PARAM]; > > Why did you use an array to store the progress information of VACUUM? > I think that it's better to use separate specific variables for them for > better code readability, for example, variables scanned_pages, > heap_total_pages, etc. > > + double progress_param_float[N_PROGRESS_PARAM]; > > Currently only progress_param_float[0] is used. So there is no need to > use an array here.
I think this kind of design may have come from the ideas expressed here (especially the last paragraph): http://www.postgresql.org/message-id/CA+TgmoYnWtNJRmVWAJ+wGLOB_x8vNOTrZnEDio=gapi5hk7...@mail.gmail.com Thanks, Amit -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
