On Wed, Sep 30, 2015 at 7:19 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > I wrote: >> Josh Berkus <j...@agliodbs.com> writes: >>> Give me source with the change, and I'll put it on a cheap, low-bandwith >>> AWS instance and hammer the heck out of it. That should raise any false >>> positives we can expect. > >> Here's a draft patch against HEAD (looks like it will work on 9.5 or >> 9.4 without modifications, too). > > BTW: in addition to whatever AWS testing Josh has in mind, it'd be good if > someone tried it on Windows. AFAIK, the self-kill() should work in the > postmaster on Windows, but that should be checked. Also, does the set of > errnos it checks cover typical deletion cases on Windows? Try both > removal of $PGDATA in toto and removal of just pg_control or just global/.
Just tested on Windows, and this is working fine for me. It seems to me as well that looking only for ENOENT and ENOTDIR is fine (here is what I looked at for reference, note the extra EXDEV or STRUNCATE for example with MS 2015): https://msdn.microsoft.com/en-us/library/5814770t.aspx -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
