On 21 September 2015 at 16:09, Tom Lane <t...@sss.pgh.pa.us> wrote: > I wrote: >> Dean Rasheed <dean.a.rash...@gmail.com> writes: >>> The problem then arises in the final carry propagation pass. During >>> this phase of the computation, the carry from one digit (which can be >>> a shade under INT_MAX / NBASE) is added to the next digit, and that's >>> where the overflow happens. > >> Nice catch! I think the comment could use a little more work, but I'll >> adjust it and push. > > After trying to rework the comment to explain what maxdig really meant > after your changes, I came to the conclusion that it'd be better to do > it as per attached. Does this look sane to you? >
Yes that looks better. It's still the same amount of extra headroom (21), but I think it's clearer your way. Regards, Dean -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
