On 2015-08-11 15:59:59 -0700, Gurjeet Singh wrote: > In your version, I don't see a comment that refers to the fact that it > works on the currently active (global variable) slot.
Hm? /* * Reserve WAL for the currently active slot. * * Compute and set restart_lsn in a manner that's appropriate for the type of * the slot and concurrency safe. */ > > I moved > > values[0] = NameGetDatum(&MyReplicationSlot->data.name); > > nulls[0] = false; > > to outside the conditional block, there seems no reason to have it in > > there? > > > > The assignment to values[0] is being done twice. We can do away with the > one in the else part of the if condition. Ugh, that's a mistake. > [1]: I altered you to it in a personal email, but probably it fell through > the cracks. I usually just check the lists for newer patch versions, sorry... Greetings, Andres Freund -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
