2015-06-08 16:49 GMT+02:00 Andres Freund <and...@anarazel.de>: > On 2015-06-08 14:44:53 +0000, Jeevan Chalke wrote: > > The following review has been posted through the commitfest application: > > make installcheck-world: tested, passed > > Implements feature: tested, passed > > Spec compliant: tested, passed > > Documentation: tested, passed > > > > This is trivial bug fix in the area of hiding error context. > > > > I observed that there are two places from which we are calling this > function > > to hide the context in log messages. Those were broken. > > Broken in which sense? They did prevent stuff to go from the server log? > > I'm not convinced that hiding stuff from the client is really > necessarily the same as hiding it from the server log. We e.g. always > send the verbose log to the client, even if we only send the terse > version to the server log. I don't mind adjusting things for > errhidecontext(), but it's not "just a bug". >
Hard to say if it is bug or not - actually it is not consistent - the name signalize so context will not be used - and there are no any other possibility to specify if it should be only for client side or for all. I don't would to do more complex than it is - just when is some exception marked as "hide context" I expect, so context will not be shown everywhere. Probably we should not to introduce function errreallyhiddencontext() :) Regards Pavel > > Greetings, > > Andres Freund > > > -- > Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-hackers >
