This is just something I noticed in passing. (I did a quick check of all the other uses of readlink in the source, and they do get this right.)
-- Abhijit P.S. Also in passing, I note that pg_rewind will follow links under any directory anywhere named pg_tblspc (which probably doesn't matter), and does not follow pg_xlog if it's a symlink (which probably does). If you want, I can submit a trivial patch for the latter.
>From d1e5cbea21bb916253bce2ad189deb1924864508 Mon Sep 17 00:00:00 2001 From: Abhijit Menon-Sen <a...@2ndquadrant.com> Date: Thu, 28 May 2015 21:03:50 +0530 Subject: readlink() doesn't nul-terminate the buffer, so we have to --- src/bin/pg_rewind/copy_fetch.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/bin/pg_rewind/copy_fetch.c b/src/bin/pg_rewind/copy_fetch.c index 9e317a2..4a7150b 100644 --- a/src/bin/pg_rewind/copy_fetch.c +++ b/src/bin/pg_rewind/copy_fetch.c @@ -126,6 +126,7 @@ recurse_dir(const char *datadir, const char *parentpath, fullpath); } + link_target[len] = '\0'; callback(path, FILE_TYPE_SYMLINK, 0, link_target); /* -- 1.9.1
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
