On Mon, May 25, 2015 at 05:34:12PM -0400, Tom Lane wrote: > Bruce Momjian <br...@momjian.us> writes: > > On Mon, May 25, 2015 at 04:52:38PM -0300, Alvaro Herrera wrote: > >> Something is wrong. See aclchk.c changes. > > > Yes, this is what I was concerned about. "aclitem" was a typedef in 9.0 > > and 9.1, and the use of that as a typedef in 9.4 is certainly odd: > > > - aclitem.ai_grantor = grantorId; > > + aclitem. ai_grantor = grantorId; > > Yeah. I think we might've gotten rid of that typedef partially in order > to fix this. > > A different strategy we could consider is "use HEAD's typedef list > even in the back branches". This would in some situations lead to > inferior-looking results in the back branches, but that's probably better > than inferior results in HEAD. (In any case, we want the same typedef > list across all branches. Then anyplace where the results diverge, there > must have been non-pgindent code changes, so that back-patching would > require manual fixups anyway.) > > A longer-term fix would be to make pgindent less stupid about this sort > of usage, but nobody's yet volunteered to dig into the guts of that code.
I assume a typedefs list is going to be a requirement of any decent C indenting tool. -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + Everyone has their own god. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
