On Sun, May 24, 2015 at 5:16 PM, Peter Geoghegan <p...@heroku.com> wrote:
> AddForeignUpdateTargets() actually won't be called with ON CONFLICT DO
> UPDATE, and so it isn't exactly true that the only obstacle to making
> FDWs support ON CONFLICT DO UPDATE is around inference of arbiter
> unique indexes on the foreign side. It's *almost* true, though.
Attached patch clears this up within the fdw-handler documentation. I
think it's worth separately noting from the existing commentary on
limitations with FDWs and ON CONFLICT.
--
Peter Geoghegan
diff --git a/doc/src/sgml/fdwhandler.sgml b/doc/src/sgml/fdwhandler.sgml
index 2361577..569a22d 100644
--- a/doc/src/sgml/fdwhandler.sgml
+++ b/doc/src/sgml/fdwhandler.sgml
@@ -399,6 +399,13 @@ AddForeignUpdateTargets (Query *parsetree,
</para>
<para>
+ Note that <function>AddForeignUpdateTargets</> will not be called
+ for <command>INSERT</> operations with an <literal>ON CONFLICT DO
+ UPDATE</> clause. Such <command>INSERT</> operations are
+ unsupported when a foreign table is targeted.
+ </para>
+
+ <para>
<programlisting>
List *
PlanForeignModify (PlannerInfo *root,
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
