Robert Haas wrote: > Also, it seems awfully unfortunate to me that we're duplicating a > whole pile of code into xlog.c here. Maybe there's no way to avoid > the code duplication, but pre_sync_fname() seems like it'd more > naturally go in fd.c than here. I dunno where walkdir should go, but > again, not in xlog.c.
Hm, there's an interest in backpatching this as a bugfix, if I understand correctly; hence the duplicated code. We could remove the duplicity later with a refactoring patch in master only. However, now that you mention a pg_control flag, it becomes evident to me that a change to pg_control cannot be back-patched ... -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
