On Thu, Apr 30, 2015 at 9:02 AM, Bruce Momjian <br...@momjian.us> wrote: > On Thu, Apr 30, 2015 at 08:46:55AM -0400, Robert Haas wrote: >> On Wed, Apr 15, 2015 at 3:38 PM, Qingqing Zhou >> <zhouqq.postg...@gmail.com> wrote: >> > In executor context, outerPlanState(node) is the same as >> > node->ss.ps.lefttree. We follow this in most places except a few. This >> > patch clean up the outliers and might save us a few instructions by >> > removing indirection. >> > >> > Most of changes are trivial. Except I take out an outerPlan nullable >> > check in grouping iterator - as a it surely has a left child. >> >> I don't see any particular reason not to do this. >> >> The patch is weird, though. If I open it with "less", I get binary >> garbage. My Mac's TextEdit app opens it OK though. > > The patch is encoded as utf-16le, and has MSDOS newlines, ^M.
I don't mind the MSDOS newlines, but the UTF-16le bit is inconvenient. UTF-8 would be much better, so I don't have to figure out how to convert. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers