On Mon, Mar 23, 2015 at 10:36 PM, Andrew Gierth <and...@tao11.riddles.org.uk> wrote: > Peter> (I simply operate on the raw Datum when hashing for hyperLogLog, > Peter> in a similar manner to the text opclass, which is safe with 8 > Peter> byte datums + pass by value int64). > > But this paragraph makes no sense, and the code currently in varlena.c > is just as wrong in its usage of hash_uint32 as I was.
Ugh, yes, not all varlena.c calls to hash_uint32() do the right thing. But then, a number of existing ones don't. I'll need to make a pass over this soon. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
