Teodor Sigaev wrote: > >Teodor's patch could use some more comments. The > >STOP_SCAN/MATCH_SCAN/CONT_SCAN > >macros are a good idea, but they probably should go into > >src/include/access/gin.h so that they can be used in all compare_partial > >implementations. > > STOP_SCAN/MATCH_SCAN/CONT_SCAN macros are moved to gin's header, and > comments are improved. > > Split patch to two: gin and module
Here you forgot to "git add" the two .sql files for the extension. They are present in the patch Heikki posted upthread but not here. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
