On Sat, Jan 31, 2015 at 8:28 AM, Marco Nenciarini <marco.nenciar...@2ndquadrant.it> wrote: > Il 30/01/15 03:54, Michael Paquier ha scritto: >> On Fri, Jan 30, 2015 at 2:49 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >>> There is at least one other bug in that function now that I look at it: >>> in event of a readdir() failure, it neglects to execute closedir(). >>> Perhaps not too significant since all existing callers will just exit() >>> anyway after a failure, but still ... >> I would imagine that code scanners like coverity or similar would not >> be happy about that. ISTM that it is better to closedir() >> appropriately in all the code paths. >> > > I've attached a new version of the patch fixing the missing closedir on > readdir error.
If readir() fails and closedir() succeeds, the return will be -1 but errno will be 0. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
