My compiler is unhappy with the latest changes to copy.c: gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -O2 -Wall -Werror -I../../../src/include -D_GNU_SOURCE -I/usr/include/libxml2 -c -o copy.o copy.c -MMD -MP -MF .deps/copy.Po copy.c: In function ‘DoCopy’: copy.c:924:30: error: ‘rte’ may be used uninitialized in this function [-Werror=uninitialized] copy.c:793:17: note: ‘rte’ was declared here cc1: all warnings being treated as errors
From what I can see, this is a pretty legitimate complaint. If stmt->relation == NULL, then rte never gets initialized, but we still do cstate->range_table = list_make1(rte). That can't be good. Also, you seem to have pushed these commits with a date more than two weeks in the past. Please don't do that! -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
