On Wed, Jan 28, 2015 at 4:46 AM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > On Wed, Jan 28, 2015 at 9:47 AM, Jim Nasby <jim.na...@bluetreble.com> wrote: > > On 1/27/15 1:04 AM, Haribabu Kommi wrote: > >> > >> Here I attached the latest version of the patch. > >> I will add this patch to the next commitfest. > > > > > > Apologies if this was covered, but why isn't the IP address an inet instead > > of text? > > Corrected the address type as inet instead of text. updated patch is attached. > > > Also, what happens if someone reloads the config in the middle of running > > the SRF? > > hba entries are reloaded only in postmaster process, not in every backend. > So there shouldn't be any problem with config file reload. Am i > missing something? >
I don't have any comment to disagree with the patch (idea and code). But I'm thinking about this patch and would not be interesting to have a FDW to manipulate the hba file? Imagine if we are able to manipulate the HBA file using INSERT/UPDATE/DELETE. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin: http://br.linkedin.com/in/fabriziomello >> Twitter: http://twitter.com/fabriziomello >> Github: http://github.com/fabriziomello