On Mon, Nov 17, 2014 at 11:13:15AM -0500, Andrew Dunstan wrote: > > This tiny change fixes what I think is a longstanding bug in psql. I causes > the first line of every cell to be counted twice, whereas it should in fact > be excluded from extra_lines / extra_row_output_lines. The bug appears to > date back to commit 43ee2282 in 2008. Changing it appears to make my > proposed pager_min_lines feature work as expected. > > So, should it be backpatched? It's a behaviour change, albeit that the > existing behaviour is a bug, and will cause the pager to be invoked on > output that is way too short (by about half a screen's height, I think).
+1 It's a bug fix that changes behavior no reasonable script could count on. Cheers, David. -- David Fetter <da...@fetter.org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david.fet...@gmail.com Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
