Hi Fujita-san, I tried to apply fdw-inh-3.patch on the latest head from master branch. It failed to apply using both patch and git apply.
"patch" failed to apply because of rejections in contrib/file_fdw/output/file_fdw.source and doc/src/sgml/ref/create_foreign_table.sgml On Fri, Nov 7, 2014 at 5:31 PM, Etsuro Fujita <fujita.ets...@lab.ntt.co.jp> wrote: > (2014/11/07 14:57), Kyotaro HORIGUCHI wrote: > >> Here are separated patches. >>>>> >>>>> fdw-chk.patch - CHECK constraints on foreign tables >>>>> fdw-inh.patch - table inheritance with foreign tables >>>>> >>>>> The latter has been created on top of [1]. >>>>> >>>> >>>> [1] >>>>> http://www.postgresql.org/message-id/540da168.3040...@lab.ntt.co.jp >>>>> >>>> >>> To be exact, it has been created on top of [1] and fdw-chk.patch. >>>> >>> >> I tried both patches on the current head, the newly added >> parameter to analyze_rel() hampered them from applying but it is >> easy to fix seemingly and almost all the other part was applied >> cleanly. >> > > Thanks for the review! > > By the way, are these the result of simply splitting of your last >> patch, foreign_inherit-v15.patch? >> >> http://www.postgresql.org/message-id/53feef94.6040...@lab.ntt.co.jp >> > > The answer is "no". > > The result of apllying whole-in-one version and this splitted >> version seem to have many differences. Did you added even other >> changes? Or do I understand this patch wrongly? >> > > As I said before, I splitted the whole-in-one version into three: 1) CHECK > constraint patch (ie fdw-chk.patch), 2) table inheritance patch (ie > fdw-inh.patch) and 3) path reparameterization patch (not posted). In > addition to that, I slightly modified #1 and #2. > > IIUC, #3 would be useful not only for the inheritance cases but for union > all cases. So, I plan to propose it independently in the next CF. > > I noticed that the latter disallows TRUNCATE on inheritance trees that >>>> contain at least one child foreign table. But I think it would be >>>> better to allow it, with the semantics that we quietly ignore the >>>> child >>>> foreign tables and apply the operation to the child plain tables, >>>> which >>>> is the same semantics as ALTER COLUMN SET STORAGE on such inheritance >>>> trees. Comments welcome. >>>> >>> >>> Done. And I've also a bit revised regression tests for both >>> patches. Patches attached. >>> >> > I rebased the patches to the latest head. Here are updated patches. > > Other changes: > > * fdw-chk-3.patch: the updated patch revises some ereport messages a > little bit. > > * fdw-inh-3.patch: I noticed that there is a doc bug in the previous > patch. The updated patch fixes that, adds a bit more docs, and revises > regression tests in foreign_data.sql a bit further. > > > Thanks, > > Best regards, > Etsuro Fujita > > > -- > Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-hackers > > -- Best Wishes, Ashutosh Bapat EnterpriseDB Corporation The Postgres Database Company
