On 10/09/14 22:53, Robert Haas wrote:
Here's what the other approach looks like. I can't really see doing
this way and then only providing hooks for those two functions, so
this is with hooks for all the send-side stuff.
Original version: 9 files changed, 295 insertions(+), 3 deletions(-)
This version: 9 files changed, 428 insertions(+), 47 deletions(-)
There is admittedly a certain elegance to providing a complete set of
hooks, so maybe this is the way to go. The remaining patches in the
patch series work with either the old version or this one; the changes
here don't affect anything else.
Anyone else have an opinion on which way is better here?
Ok so it is more than 20 lines :)
I do like this approach more though, it looks cleaner to me.
On 10/09/14 22:53, Robert Haas wrote:
+extern int (*pq_putmessage_hook)(char msgtype, const char *s, size_tlen);
+extern int (*pq_flush_hook)(void);
Btw you forgot to remove the above.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
