Re: [HACKERS] WIP Patch for GROUPING SETS phase 1

[Stephen Frost]

* Andrew Gierth (and...@tao11.riddles.org.uk) wrote:
> Having now spent some more time looking, I believe there is a solution
> which makes it unreserved which does not require any significant pain
> in the code.  I'm not entirely convinced that this is the right
> approach in the long term, but it might allow for a more planned
> transition.
> 
> The absolute minimum seems to be:
> 
>  GROUPING as a col_name_keyword (since GROUPING(x,y,...) in the select
>  list as a <grouping operation> looks like a function call for any
>  argument types)
> 
>  CUBE, ROLLUP, SETS as unreserved_keyword

This means

GROUP BY cube(x,y)
GROUP BY (cube(x,y))
GROUP BY cube(x)

all end up with different meanings though, right?

I'm not sure that's really a better situation.

        Thanks,

                Stephen

signature.asc
Description: Digital signature