Hello

Tomorrow I'll do a review

fast check



   <para>
+    To aid the user in finding instances of simple but common problems
before
+    they cause harm, <application>PL/PgSQL</> provides a number of
additional
+    <replaceable>checks</>. When enabled, depending on the configuration,
they
+    can be used to emit either a <literal>WARNING</> or an
<literal>ERROR</>
+    during the compilation of a function.
+   </para>

>>>provides a number of additional<<<

There will be only one check in 9.4, so this sentence is confusing and
should be reformulated.

Regards

Pavel



2014-03-18 20:29 GMT+01:00 Petr Jelinek <p...@2ndquadrant.com>:

>
> On 18/03/14 20:15, Pavel Stehule wrote:
>
>
> 2014-03-18 20:14 GMT+01:00 Simon Riggs <si...@2ndquadrant.com>:
>
>> On 18 March 2014 19:04, Pavel Stehule <pavel.steh...@gmail.com> wrote:
>>
>> > I don't think so only "shadow" is good name for some check. Maybe
>> > "shadow-variables-check"
>>
>>  "shadowed-variables" would be a better name.
>>
>
> +1
>
>
> Attached V4 uses "shadowed-variables" instead of "shadow".
>
> --
>  Petr Jelinek                  http://www.2ndQuadrant.com/
>
>  PostgreSQL Development, 24x7 Support, Training & Services
>
>

Reply via email to