On Tue, Feb 25, 2014 at 1:44 PM, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > Etsuro Fujita wrote: >> This is a small patch to improve comments in tablecmds.c. Please find >> attached a patch. > > I find both patched and unpatched to be pretty illegible. How about > something like > >> /* >> - * Execute ALTER TABLE/INDEX/SEQUENCE/VIEW/FOREIGN TABLE RENAME >> + * Execute ALTER <relation type> RENAME >> + * This routine supports tables, indexes, sequences, views, >> + * and foreign tables >> */
I don't find that to be an improvement. > and the two other ones with something like this: > >> /* >> - * Grab an exclusive lock on the target table, index, sequence or view, >> - * which we will NOT release until end of transaction. >> + * Grab an exclusive lock on the target relation, >> + * which we will NOT release until >> + * end of transaction. But I do like that better. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
