On 2014-02-24 13:16:39 -0500, Bruce Momjian wrote: > On Mon, Feb 24, 2014 at 07:09:29PM +0100, Andres Freund wrote: > > On 2014-02-24 12:45:12 -0500, Bruce Momjian wrote: > > > On Wed, Feb 12, 2014 at 09:04:45PM -0500, Bruce Momjian wrote: > > > > As others, I am concerned about people being confused when funny-looking > > > > trigger names suddenly appearing when you disable all table triggers. > > > > > > > > What I ended up doing is to create a user and internal section when > > > > displaying disabled triggers: > > > > > > > > Disabled user triggers: > > > > check_update BEFORE UPDATE ON orders FOR EACH ROW EXECUTE > > > > PROCEDURE trigf() > > > > Disabled internal triggers: > > > > "RI_ConstraintTrigger_c_16409" AFTER INSERT ON orders FROM > > > > customer NOT DEF ... > > > > "RI_ConstraintTrigger_c_16410" AFTER UPDATE ON orders FROM > > > > customer NOT DEF ... > > > > > > > > I kept the "Triggers" section unchanged, showing only user triggers. I > > > > also updated the code to handle 8.3+ servers. > > > > > > > > Patch attached. > > > > > > Patch applied. > > > > Thanks. It'd have been nice tho, to mention FabrÃzio in the commit > > message as the patch's author. > > Uh, I was thinking of that, but I basically rewrote the patch from > scratch and changed its visible behavior, so I was worried about perhaps > blaming him if it introduced a bug. I should have said "original patch > by ...", but because so much of it was new, I didn't bother.
I just seems nicer to relatively new contributors to mention their names when they try to contribute. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
