On Mon, Jan 27, 2014 at 11:29 AM, Michael Paquier
<michael.paqu...@gmail.com> wrote:
> Hi,
>
> Please find attached an updated patch (context diffs) improving the
> comments related to ALTER SYSTEM. This patch does nothing for the
> suffix tmp/temp used in a couple of places of the code, it only
> corrects some typos and makes the comments more consistent with
> current code.
And I almost forgot the second patch simply changing the suffix from
temp to tmp for the temporary conf file... Now attached.
Regards,
-- 
Michael
*** a/src/backend/replication/basebackup.c
--- b/src/backend/replication/basebackup.c
***************
*** 834,840 **** sendDir(char *path, int basepathlen, bool sizeonly, List 
*tablespaces)
  
                /* skip auto conf temporary file */
                if (strncmp(de->d_name,
!                                       PG_AUTOCONF_FILENAME ".temp",
                                        sizeof(PG_AUTOCONF_FILENAME) + 4) == 0)
                        continue;
  
--- 834,840 ----
  
                /* skip auto conf temporary file */
                if (strncmp(de->d_name,
!                                       PG_AUTOCONF_FILENAME ".tmp",
                                        sizeof(PG_AUTOCONF_FILENAME) + 4) == 0)
                        continue;
  
*** a/src/backend/utils/misc/guc.c
--- b/src/backend/utils/misc/guc.c
***************
*** 6671,6677 **** AlterSystemSetConfigFile(AlterSystemStmt * altersysstmt)
        canonicalize_path(AutoConfFileName);
        snprintf(AutoConfTmpFileName, sizeof(AutoConfTmpFileName), "%s.%s",
                         AutoConfFileName,
!                        "temp");
  
        /*
         * one backend is allowed to operate on postgresql.auto.conf file, to
--- 6671,6677 ----
        canonicalize_path(AutoConfFileName);
        snprintf(AutoConfTmpFileName, sizeof(AutoConfTmpFileName), "%s.%s",
                         AutoConfFileName,
!                        "tmp");
  
        /*
         * one backend is allowed to operate on postgresql.auto.conf file, to
-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to