On Fri, Dec 20, 2013 at 9:06 AM, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > Michael Paquier escribió: >> On Fri, Dec 20, 2013 at 1:05 PM, Sawada Masahiko <sawada.m...@gmail.com> >> wrote: > >> > Sorry the patch which I attached has wrong indent on pg_controldata. >> > I have modified it and attached the new version patch. >> Now that you send this patch, I am just recalling some recent email >> from Tom arguing about avoiding to mix lower and upper-case characters >> for a GUC parameter name: >> http://www.postgresql.org/message-id/30569.1384917...@sss.pgh.pa.us >> >> To fullfill this requirement, could you replace walLogHints by >> wal_log_hints in your patch? Thoughts from others? > > The issue is with the user-visible variables, not with internal > variables implementing them. I think the patch is sane. (Other than > the fact that it was posted as a patch-on-patch instead of > patch-on-master).
But spelling it the same way everywhere really improves greppability. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
